add deprecation warning for specifying strict_exception_groups=False #2941
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2941 +/- ##
=======================================
Coverage 99.64% 99.64%
=======================================
Files 116 117 +1
Lines 17521 17564 +43
Branches 3151 3166 +15
=======================================
+ Hits 17459 17502 +43
Misses 43 43
Partials 19 19
|
Zac-HD
approved these changes
Jan 31, 2024
|
Making sure, nothing can go wrong with the literal |
Right, if somebody is supplying a falsy value of an incorrect type they're not gonna get a warning. So I suppose I could do if not strict_exception_groups and strict_exception_groups is not None:
...Don't think we need to be that defensive, but I guess it also doesn't hurt. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wasn't totally sure which issue to refer to, ended up going with #2929
the removed
withblock intest_subprocesswas added to try and track down some weirdness in #2886 (comment) - but I don't think it served much of a purpose in the end, so opted now to remove it instead of wrapping it in apytest.warns.